[PATCH] D33128: [AsmParser] Mnemonic Spell Corrector

Simon Dardis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 19 10:15:01 PDT 2017


sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.

LGTM. We should see if @rengolin has any further comments.



================
Comment at: utils/TableGen/AsmMatcherEmitter.cpp:2726
+    OS << "  for (auto I = std::begin(MatchTable0); I < End; I++) {\n";
+    OS << "    //Ignore unsupported instructions.\n";
+    OS << "    if ((FBS & I->RequiredFeatures) != I->RequiredFeatures)\n";
----------------
Space after the '//'.


================
Comment at: utils/TableGen/AsmMatcherEmitter.cpp:2732
+    OS << "    // Avoid recomputing the edit distance for the same string.\n";
+    OS << "    if(T.equals(Prev))\n";
+    OS << "      continue;\n";
----------------
Space after the if.


https://reviews.llvm.org/D33128





More information about the llvm-commits mailing list