[lld] r305520 - Remove some non-determinstic numbers from pdb test.

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 19 09:58:07 PDT 2017


On Mon, Jun 19, 2017 at 9:56 AM Zachary Turner <zturner at google.com> wrote:

> I guess non deterministic is the wrong word. "Volatile" or "fragile" might
> be better. Imagine a number like a file size, where when you add something
> the size changes. In this case I believe it was a stream length, where
> adding more data changed the size of the stream, but where someone
> writing/reading the test could not possibly know what number was supposed
> to be there, so like an implementation detail
>

Ah, yep yep - no worries (yeah, we do similar things in the DWARF testing
for sure - just matching regex to offsets rather than hard coding them, so
they're resilient to new attributes being added/removed, etc).


> On Mon, Jun 19, 2017 at 9:40 AM David Blaikie <dblaikie at gmail.com> wrote:
>
>> Nondeterministic?
>>
>> Is that a necessary function of the format or what? LLVM tools usually
>> try very hard to be deterministic - I'd be wary of making any intentionally
>> non-deterministic.
>>
>> On Thu, Jun 15, 2017 at 3:42 PM Zachary Turner via llvm-commits <
>> llvm-commits at lists.llvm.org> wrote:
>>
>>> Author: zturner
>>> Date: Thu Jun 15 17:41:45 2017
>>> New Revision: 305520
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=305520&view=rev
>>> Log:
>>> Remove some non-determinstic numbers from pdb test.
>>>
>>> Modified:
>>>     lld/trunk/test/COFF/pdb.test
>>>
>>> Modified: lld/trunk/test/COFF/pdb.test
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/lld/trunk/test/COFF/pdb.test?rev=305520&r1=305519&r2=305520&view=diff
>>>
>>> ==============================================================================
>>> --- lld/trunk/test/COFF/pdb.test (original)
>>> +++ lld/trunk/test/COFF/pdb.test Thu Jun 15 17:41:45 2017
>>> @@ -183,17 +183,17 @@ RAW-NEXT:         IMAGE_SCN_MEM_READ
>>>  RAW:                             Section Map
>>>  RAW-NEXT: ============================================================
>>>  RAW-NEXT:   Section 0000 | ovl = 0, group = 0, frame = 0, name = 1
>>> -RAW-NEXT:                  class = 65535, offset = 0, size = 12
>>> +RAW-NEXT:                  class = 65535, offset = 0, size =
>>>  RAW-NEXT:                  flags = read | 32 bit addr | selector
>>>  RAW-NEXT:   Section 0001 | ovl = 1, group = 0, frame = 0, name = 2
>>> -RAW-NEXT:                  class = 65535, offset = 0, size = 22
>>> +RAW-NEXT:                  class = 65535, offset = 0, size =
>>>  RAW-NEXT:                  flags = read | execute | 32 bit addr |
>>> selector
>>>  RAW-NEXT:   Section 0002 | ovl = 2, group = 0, frame = 0, name = 3
>>> -RAW-NEXT:                  class = 65535, offset = 0, size = 8
>>> +RAW-NEXT:                  class = 65535, offset = 0, size =
>>>  RAW-NEXT:                  flags = read | 32 bit addr | selector
>>>  RAW-NEXT:   Section 0003 | ovl = 3, group = 0, frame = 0, name = 4
>>> -RAW-NEXT:                  class = 65535, offset = 0, size = 119
>>> +RAW-NEXT:                  class = 65535, offset = 0, size =
>>>  RAW-NEXT:                  flags = read | 32 bit addr | selector
>>>  RAW-NEXT:   Section 0004 | ovl = 4, group = 0, frame = 0, name = 5
>>> -RAW-NEXT:                  class = 65535, offset = 0, size = 4294967295
>>> +RAW-NEXT:                  class = 65535, offset = 0, size =
>>>  RAW-NEXT:                  flags = 32 bit addr | absolute addr
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at lists.llvm.org
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170619/2be61687/attachment.html>


More information about the llvm-commits mailing list