[PATCH] D34069: [DAGCombiner] Fix PR33368 (vector extend/truncate optimization)

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 19 09:30:53 PDT 2017


RKSimon added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:15085
+  unsigned ExtDstSizeInBits = N0.getScalarValueSizeInBits();
+  unsigned ExtScale = ExtDstSizeInBits / ExtSrcSizeInBits;
 
----------------
Add a check that (ExtDstSizeInBits % ExtSrcSizeInBits) == 0? Either an assert or early-out


https://reviews.llvm.org/D34069





More information about the llvm-commits mailing list