t.p.northover accepted this revision. t.p.northover added a comment. This revision is now accepted and ready to land. This looks fine to me, but I'll understand if anyone wants someone more x86y to have a look too. https://reviews.llvm.org/D33952