[PATCH] D34160: [Power9] Exploit vinserth instruction

Graham Yiu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 19 08:05:33 PDT 2017


gyiu added inline comments.


================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:1629
+  uint32_t Mask = 0;
+  uint32_t OriginalOrderLow = 0x1234567;
+  uint32_t OriginalOrderHigh = 0x89ABCDEF;
----------------
jtony wrote:
> Is there any reason why we use uint32_t? If not, I would use unsigned instead to make it consistent. We are using both unsigned and uint32_t in this file.
I think using uint32_t is appropriate here because I want to illustrate that I'm using 32-bits exactly.  Using 'unsigned int' would be fine as well, but I don't think it's as clear that I'm looking for 32-bits exactly.


Repository:
  rL LLVM

https://reviews.llvm.org/D34160





More information about the llvm-commits mailing list