[PATCH] D30751: [MachineCopyPropagation] Extend pass to do COPY source forwarding

Hiroshi Inoue via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 19 07:23:54 PDT 2017


inouehrs added a comment.

I have implemented mostly same optimization in PowerPC backend (independently from this patch) and submitted a patch https://reviews.llvm.org/D34193 .
After I realized this patch based on a comment from @MatzeB, I abandoned my patch because this patch is platform neutral and so has wider coverage.
Since I see performance improvements in SPECCPU with my patch, I hope this patch gives similar performance gains.



================
Comment at: lib/CodeGen/MachineCopyPropagation.cpp:590
+
+      forwardUses(*MI);
+
----------------
Do we need to execute forwardUses after virtual register rewriting again?


================
Comment at: lib/CodeGen/MachineCopyPropagation.cpp:663
+
+    forwardUses(*MI);
+
----------------
Ditto. Do we need this after virtual register rewriting again?


https://reviews.llvm.org/D30751





More information about the llvm-commits mailing list