[PATCH] D34132: Add scripts to perform LNT submissions

Kristof Beyls via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 19 07:13:58 PDT 2017


kristof.beyls added a comment.

There is quite a bit of code that is duplicated from LNT to test-suite as part of this patch.
I'm not entirely sure if having this much code duplication between LNT and test-suite is desirable, unless this is part of a bigger redesign, like we discussed in January in the thread starting roughly at http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20170123/423073.html, with a nicer design in the end?

As I said before, I like the conceptual idea of having the functionality to drive the test-suite being part of the "test-suite" project rather than the "LNT" project, but I haven't thought further about practical consequences, like potential code duplication, showing up here.
My gut feel is that most of these issues could go away in the end if we'd put all code to drive the test-suite in test-suite, and make LNT "just" the web server/database/analysis functionality.
But it's probably best to make sure we agree that's where we want to end up before adding a lot of code duplication as part of this first step patch?

Apart from my other thoughts above, I think this is the point where it is useful to start adding some documentation on how to run the tests for the test-suite framework, e.g. similar in spirit to http://lnt.readthedocs.io/en/latest/developer_guide.html.



================
Comment at: utils/lntsubmit:28
+p.add_argument('-u', '--url', default=None,
+               help="Submit PUT request to jenkins server")
+config = p.parse_args()
----------------
s/jenkins/LNT/?


================
Comment at: utils/tests/lntsubmit-minimal.test:1
+RUN: tail -n +2 %s | head -n 31 > %t && ../lntsubmit -n JustATestMachine -o 123456 %t | FileCheck %s
+{
----------------
using tail and head with hard-coded numbers seems a bit too icky to me.
Would something like:

```
RUN: grep -v '^#' %s > %s
```

be nicer? We'd of course have to add # signs at the beginning of lines that aren't the JSON-input. I think that gives the advantage that the test files are slightly easier to parse as a human, and they look more like other test files using FileCheck in various LLVM projects.


Repository:
  rL LLVM

https://reviews.llvm.org/D34132





More information about the llvm-commits mailing list