[PATCH] D34348: [mips] Allow $AT to be used as a register name

Simon Dardis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 19 06:23:46 PDT 2017


sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.

Nit inlined.

Also you should extend test/MC/Mips/mips64-register-names-{n32-n64,o32}.s .

LGTM with those nits addressed.



================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:5109-5110
            .Case("zero", 0)
            .Case("at", 1)
+           .Case("AT", 1)
            .Case("a0", 4)
----------------
.Cases("at", "AT", 1) instead.


https://reviews.llvm.org/D34348





More information about the llvm-commits mailing list