[PATCH] D34144: [CodeGen] Add generic MacroFusion pass.

[Phil Camp via Phabricator via llvm-commits]

FlameTop added a comment.

Hi.

This change is failing to build on windows buildbots.

http://lab.llvm.org:8011/waterfall?builder=llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast&builder=llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast

C:\PROGRA~2\MICROS~1.0\VC\bin\amd64\cl.exe   /nologo /TP -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_GLOBAL_ISEL -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib\CodeGen -IC:\Buildbot\Slave\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\lib\CodeGen -Iinclude -IC:\Buildbot\Slave\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:strictStrings /Oi /Zc:rvalueCast /https://reviews.llvm.org/W4 -wd4141 -wd4146 -wd4180 -wd4244 -wd4258 -wd4267 -wd4291 -wd4345 -wd4351 -wd4355 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4800 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4324 -w14062 -we4238 /MD /https://reviews.llvm.org/owners/package/2/ /Ob2   -UNDEBUG  /EHs-c- /GR- /showIncludes /Folib\CodeGen\CMakeFiles\LLVMCodeGen.dir\MacroFusion.cpp.obj /Fdlib\CodeGen\CMakeFiles\LLVMCodeGen.dir\ /FS -c C:\Buildbot\Slave\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\lib\CodeGen\MacroFusion.cpp
C:\Buildbot\Slave\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\lib\CodeGen\MacroFusion.cpp(139): error C2668: 'llvm::make_unique': ambiguous call to overloaded function
C:\Buildbot\Slave\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\include\llvm/ADT/STLExtras.h(939): note: could be 'std::unique_ptr<`anonymous-namespace'::MacroFusion,std::default_delete<_Ty>> llvm::make_unique<`anonymous-namespace'::MacroFusion,llvm::ShouldSchedulePredTy&,bool>(llvm::ShouldSchedulePredTy &,bool &&)'

  with
  [
      _Ty=`anonymous-namespace'::MacroFusion
  ]

C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE\memory(1628): note: or       'std::unique_ptr<`anonymous-namespace'::MacroFusion,std::default_delete<_Ty>> std::make_unique<`anonymous-namespace'::MacroFusion,llvm::ShouldSchedulePredTy&,bool>(llvm::ShouldSchedulePredTy &,bool &&)' [found using argument-dependent lookup]

  with
  [
      _Ty=`anonymous-namespace'::MacroFusion
  ]

C:\Buildbot\Slave\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\lib\CodeGen\MacroFusion.cpp(139): note: while trying to match the argument list '(llvm::ShouldSchedulePredTy, bool)'
C:\Buildbot\Slave\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\lib\CodeGen\MacroFusion.cpp(146): error C2668: 'llvm::make_unique': ambiguous call to overloaded function
C:\Buildbot\Slave\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\include\llvm/ADT/STLExtras.h(939): note: could be 'std::unique_ptr<`anonymous-namespace'::MacroFusion,std::default_delete<_Ty>> llvm::make_unique<`anonymous-namespace'::MacroFusion,llvm::ShouldSchedulePredTy&,bool>(llvm::ShouldSchedulePredTy &,bool &&)'

  with
  [
      _Ty=`anonymous-namespace'::MacroFusion
  ]

C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE\memory(1628): note: or       'std::unique_ptr<`anonymous-namespace'::MacroFusion,std::default_delete<_Ty>> std::make_unique<`anonymous-namespace'::MacroFusion,llvm::ShouldSchedulePredTy&,bool>(llvm::ShouldSchedulePredTy &,bool &&)' [found using argument-dependent lookup]

  with
  [
      _Ty=`anonymous-namespace'::MacroFusion
  ]

C:\Buildbot\Slave\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\lib\CodeGen\MacroFusion.cpp(146): note: while trying to match the argument list '(llvm::ShouldSchedulePredTy, bool)'

regards


https://reviews.llvm.org/D34144