[PATCH] D34095: [DAG] Prevent CombineTo from deleting already deleted nodes

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 19 04:13:15 PDT 2017


RKSimon added a reviewer: chandlerc.
RKSimon added a subscriber: chandlerc.
RKSimon added a comment.

Adding @chandlerc who refactored this code at https://reviews.llvm.org/rL214623



================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:948
   // something else needing this node.
-  if (N->use_empty())
+  if (N->use_empty() && N->getOpcode() != ISD::DELETED_NODE)
     deleteAndRecombine(N);
----------------
Not sure if its relevant but there are several other places that call deleteAndRecombine on a node under similar circumstances.


https://reviews.llvm.org/D34095





More information about the llvm-commits mailing list