[PATCH] D33888: [GlobalISel][X86] Fold FI/G_GEP into LDR/STR instruction addressing mode.

Guy Blank via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 19 04:08:01 PDT 2017


guyblank accepted this revision.
guyblank added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Target/X86/X86InstructionSelector.cpp:376
+  X86AddressMode AM;
+  if (!X86SelectAddress(*MRI.getVRegDef(I.getOperand(1).getReg()), AM, MRI))
+    return false;
----------------
zvi wrote:
> Should we exit when optimizations are disabled?
I think it is reasonable to always try to fold the address calculation.
It isn't a big effort to do so, and it simplifies the generated code.


https://reviews.llvm.org/D33888





More information about the llvm-commits mailing list