[PATCH] D30443: Add a propagateKnownNonPoison helper

Sanjoy Das via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 17 15:17:33 PDT 2017


sanjoy added inline comments.


================
Comment at: include/llvm/Analysis/ValueTracking.h:422
+  /// Starting with the assumption that \p I is not poison, fill \p
+  /// NonPoison with a set of values that are also known to not be
+  /// poison.  Internally this is a simple worklist algorithm around
----------------
reames wrote:
> Ok, this interface is vague.  Which set of values?  And why might we wan this?
> And why might we wan this?

As you've noted later, this is used in D30446

> Which set of values?

Not sure how I can make it clearer in the documentation.



https://reviews.llvm.org/D30443





More information about the llvm-commits mailing list