[PATCH] D33383: [GSoC] Flag value completion for clang

[Yuka Takahashi via Phabricator via llvm-commits]

yamaguchi marked 2 inline comments as done.
yamaguchi added inline comments.


================
Comment at: llvm/lib/Option/OptTable.cpp:198
+      continue;
+    std::string S = "-" + std::string(In.Name);
+    std::string C = (Command[1] == "=") ? 
----------------
yamaguchi wrote:
> teemperor wrote:
> > Hmm, will this work with "--" flags? Also, same as above with naming `S` and `C`.
> @teemperor 
> Do you think we should add some sample value completions to flags start with "--" (such as --target) and flags which don't contain "=" (such as -mllvm <value>) ?
> This part of code is rather ad hoc right now for -stdlib.
I had add support for this in this update as well, thanks.


https://reviews.llvm.org/D33383