[PATCH] D34240: [WebAssembly] Expansion of llvm.umul.overflow with i64 type operands.

[Jatin Bhateja via Phabricator via llvm-commits]

jbhateja marked 6 inline comments as done.
jbhateja added a comment.

In https://reviews.llvm.org/D34240#782612, @efriedma wrote:

> I apologize, my review last night wasn't very insightful.  Hopefully better comments today.
>
>  ---
>
> test/CodeGen/ARM/umulo-32.ll and test/CodeGen/SPARC/64cond.ll are tests for other targets which use this codepath.  Please verify that you aren't changing the generated code for those testcases.  (I guess wasm in particular breaks it can't return an i128 in registers?)


Review comments incorpocated.  Verified the additional tests mentioned no changes in generated code with changes.


https://reviews.llvm.org/D34240