[PATCH] D34312: [NewPM/Inliner] Reduce threshold for cold callsites in the non-PGO case

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: lib/Analysis/InlineCost.cpp:691
           Threshold = MinIfValid(Threshold, Params.ColdCallSiteThreshold);
+        } else if (!PSI->hasProfileSummary()) {
+          auto CallSiteBB = CS.getInstruction()->getParent();
----------------
Can the static/local call site check and the global cold site check be moved into a helper function such as CallAnalyzer::isColdCallsite ?


================
Comment at: test/Transforms/Inline/inline-cold-callsite.ll:35
+
+if.then:
+; CHECK: call void @callee
----------------
change the label name to 'cold:'.


https://reviews.llvm.org/D34312