[PATCH] D34316: Update documentation to reflection disuse of external cvtres.

[Eric Beckmann via Phabricator via llvm-commits]

ecbeckmann created this revision.

https://reviews.llvm.org/D34316

Files:
  lld/COFF/Driver.cpp
  lld/docs/windows_support.rst


Index: lld/docs/windows_support.rst
===================================================================
--- lld/docs/windows_support.rst
+++ lld/docs/windows_support.rst
@@ -49,7 +49,7 @@
 
 Windows resource files support
   :good:`Done`. If an ``.res`` file is given, LLD converts the file to a COFF
-  file using ``cvtres.exe`` command and link it.
+  file using LLVM's Object library.
 
 Safe Structured Exception Handler (SEH)
   :good:`Done` for both x86 and x64.
Index: lld/COFF/Driver.cpp
===================================================================
--- lld/COFF/Driver.cpp
+++ lld/COFF/Driver.cpp
@@ -936,9 +936,9 @@
     Config->Machine = AMD64;
   }
 
-  // Windows specific -- Input files can be Windows resource files (.res files).
-  // We invoke cvtres.exe to convert resource files to a regular COFF file
-  // then link the result file normally.
+  // Input files can be Windows resource files (.res files). We use
+  // WindowsResource to convert resource files to a regular COFF file,
+  // then link the resulting file normally.
   if (!Resources.empty())
     addBuffer(convertResToCOFF(Resources));
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D34316.102930.patch
Type: text/x-patch
Size: 1129 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170617/0eef0189/attachment.bin>