[PATCH] D34177: [DWARF] Partial verification for .apple_names accelerator table in llvm-dwarfdump output.

[David Blaikie via llvm-commits]

On Fri, Jun 16, 2017 at 3:06 PM Spyridoula Gravani via Phabricator <
reviews at reviews.llvm.org> wrote:

> sgravani marked 4 inline comments as done.
> sgravani added inline comments.
>
>
> ================
> Comment at: llvm/trunk/lib/DebugInfo/DWARF/DWARFVerifier.cpp:290-293
> +  if (!AppleNames.extract()) {
> +    OS << "error: cannot extract .apple_names accelerator table\n";
> +    return false;
> +  }
> ----------------
> dblaikie wrote:
> > Is this error produced when the section is not present? Is that the
> right behavior/does this need an error in that case?
> In such a case, we should not have any output message.
> Thanks for noticing! fixed it in new commit.
>

Did you include a test case? (did you mean an actual commit, or update to
this review - I didn't check if this has already been submitted. If it's an
actual commit, it's helpful to have the revision number here in the thread
for reference)


>
>
> ================
> Comment at: llvm/trunk/lib/DebugInfo/DWARF/DWARFVerifier.cpp:310
> +  }
> +  return NumAppleNamesErrors == 0;
> +}
> ----------------
> dblaikie wrote:
> > Probably use a boolean flag if that's the only thing that matters?
> ("HasErrors"?)
> I prefer to stay consistent with the naming in the other handle[section]
> functions in the class.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D34177
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170616/f10e95eb/attachment.html>