[PATCH] D34296: [Dominators] Don't compute DFS InOut numbers eagerly.

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 16 14:55:19 PDT 2017


kuhar created this revision.

DFS InOut numbers currently get eagerly computer upon DomTree construction. They are only needed to answer dome dominance queries and they get invalidated by updates and recalculations. Because of that, it is faster in practice to compute them lazily when they are actually needed.

Clang built without this patch takes 6m 45s to boostrap on my machine, and with the patch applied 6m 38s.


Repository:
  rL LLVM

https://reviews.llvm.org/D34296

Files:
  include/llvm/Support/GenericDomTreeConstruction.h


Index: include/llvm/Support/GenericDomTreeConstruction.h
===================================================================
--- include/llvm/Support/GenericDomTreeConstruction.h
+++ include/llvm/Support/GenericDomTreeConstruction.h
@@ -255,8 +255,6 @@
   // Free temporary memory used to construct idom's
   DT.IDoms.clear();
   DT.Info.clear();
-
-  DT.updateDFSNumbers();
 }
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D34296.102882.patch
Type: text/x-patch
Size: 383 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170616/0a54c926/attachment.bin>


More information about the llvm-commits mailing list