[PATCH] D34181: MachineInstr: Reason locally about some memory objects before going to AA.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a reviewer: arsenm.
efriedma added a comment.

Any idea what effect this has on performance, if any?

The changes to the AMDGPU tests need more explanation.



================
Comment at: lib/CodeGen/MachineInstr.cpp:1667
+  if (!SameVal) {
+    const PseudoSourceValue *PSVa = MMOa->getPseudoValue();
+    const PseudoSourceValue *PSVb = MMOb->getPseudoValue();
----------------
This looks weird.  If getPseudoValue() is non-null, getValue() is null; therefore PSVa is always null here.


https://reviews.llvm.org/D34181