[PATCH] D34265: Switch external cvtres.exe for llvm's own resource library.In this patch, I flip the switch in DriverUtils from using the externalcvtres.exe tool to using the Windows Resource library in llvm.I also fixed a bug where .rsrc sections were...

Eric Beckmann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 16 10:31:31 PDT 2017


ecbeckmann added a comment.

In https://reviews.llvm.org/D34265#781998, @ruiu wrote:

> As a convention, please write a short summary (ideally less than 80 chars) on the first line of a commit message, so that they are not wrapped around
>  ... like this.


Yes sorry about this.  In the commit message just the first sentence is the summary and the rest is the summary below.  I think arc diff put it all together though.


https://reviews.llvm.org/D34265





More information about the llvm-commits mailing list