[PATCH] D34160: [Power9] Exploit vinserth instruction

[Eric Christopher via Phabricator via llvm-commits]

echristo added a comment.

Go ahead and submit the rename separately (if you don't have commit access send me a patch and I'll do it). I would prefer to try to minimize boolean arguments - in this case you're adding a few more including a true/false and a return value one. Feel free to refactor the code around it to require fewer booleans or have multiple functions with helper functions that end up being called.

Thanks!



================
Comment at: lib/Target/PowerPC/PPCISelLowering.h:515
+    bool isVINSERTHMask(ShuffleVectorSDNode *N, unsigned &ShiftElts,
+                        unsigned &InsertAtByte, bool &Swap, bool IsLE);
+
----------------
jtony wrote:
> The community doesn't like the bool parameters here. But I am not sure whether we must remove them or it is just nice to do. 
Please do. 


Repository:
  rL LLVM

https://reviews.llvm.org/D34160