[PATCH] D34257: [PDB] Start emitting source file and line information
Zachary Turner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 15 18:31:30 PDT 2017
zturner added inline comments.
================
Comment at: lld/test/COFF/Inputs/pdb_lines_1.yaml:6
+sections:
+ - Name: .drectve
+ Characteristics: [ IMAGE_SCN_LNK_INFO, IMAGE_SCN_LNK_REMOVE ]
----------------
If we're just testing lines, can we delete everything but the `.debug$S` section with the appropriate chunk? Seems like you could nuke this entire file down to a single `.debug$S` section with nothing but a lines section and a checksums section.
================
Comment at: lld/test/COFF/Inputs/pdb_lines_1.yaml:205
+ Alignment: 1
+ SectionData: 04000000F10000004D000000290047110000000000000000000000000E00000004000000090000000310000000000000000000666F6F001C001210280000000000000000000000000000000000000000002042110002004F11000000F20000003000000000000000000000000E000000180000000300000024000000000000000200008004000000030000800900000004000080
+ Subsections:
----------------
See earlier comment about deleting unnecessary subsections, but that said, don't specify both `SectionData` and `Subsections`. One or the other. (I should probably find a way to make the yaml error out if you have both)
================
Comment at: lld/test/COFF/Inputs/pdb_lines_1.yaml:302
+ Type: IMAGE_REL_AMD64_ADDR32NB
+symbols:
+ - Name: '@comp.id'
----------------
Delete all this stuff too?
================
Comment at: lld/test/COFF/Inputs/pdb_lines_2.yaml:6
+sections:
+ - Name: .drectve
+ Characteristics: [ IMAGE_SCN_LNK_INFO, IMAGE_SCN_LNK_REMOVE ]
----------------
Same deleting comments apply to this file.
https://reviews.llvm.org/D34257
More information about the llvm-commits
mailing list