[PATCH] D34168: [cfi] CFI-ICall for ThinLTO.

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added inline comments.


================
Comment at: lib/Transforms/IPO/LowerTypeTests.cpp:1415
 
+static bool IsFunctionLive(StringRef Name, const ModuleSummaryIndex *Summary) {
+  auto GUID = GlobalValue::getGUID(GlobalValue::dropLLVMManglingEscape(Name));
----------------
pcc wrote:
> You could remove this function and use `ModuleSummaryIndex::isGUIDLive` now.
I did not notice this before, but isGUIDLive thinks that all external functions are dead,  because only definitions have value summaries.




Repository:
  rL LLVM

https://reviews.llvm.org/D34168