[PATCH] D33680: [ELF] - Resolve references properly when using .symver directive

[George Rimar via llvm-commits]

Ok, I see.

i am going to update this patch with change to remove temp vector at my early tomorrow (+10-15h to atm).

Best regards,
George | Developer | Access Softek, Inc

________________________________________
От: Rafael Avila de Espindola <rafael.espindola at gmail.com>
Отправлено: 15 июня 2017 г. 23:17
Кому: George Rimar; reviews+D33680+public+796463829d622830 at reviews.llvm.org; ruiu at google.com
Копия: Evgeny Leviant; llvm-commits at lists.llvm.org; emaste at freebsd.org
Тема: Re: [PATCH] D33680: [ELF] - Resolve references properly when using .symver directive

I actually find the loop simpler than the temp vector. The vector still
needs a comment, and with a comment the loop is just as easy to
understand.

Cheers,
Rafael

George Rimar <grimar at accesssoftek.com> writes:
> Yes, that is true for sure, but it complicates logic, no ?
>
> Temp vector still keep it simple,
> though if you think it is really better, I have probably no major arguments not to do that,
> it is a matter of taste it seems.
>
> Rui, will you be ok to do this change then ?
>
> George.