[PATCH] D34144: [CodeGen] Add generic MacroFusion pass.

[Evandro Menezes via Phabricator via llvm-commits]

evandro added inline comments.


================
Comment at: lib/CodeGen/MacroFusion.cpp:54
+    // it with one in its predecessors.
+    for (SUnit &ISU : DAG->SUnits)
+      scheduleAdjacentImpl(DAG, ISU);
----------------
I'm inclined to agree that this should be enough.


================
Comment at: lib/CodeGen/MacroFusion.cpp:78
+    // Ignore dependencies that don't enforce ordering.
+    if (Dep.isWeak())
+      continue;
----------------
I wonder if this should actually be `Dep.isData()`, since other dependencies probably don't matter to instruction fusion.


https://reviews.llvm.org/D34144