[PATCH] D34221: [ELF] - Resolve references properly when using .symver directive (2)

[George Rimar via llvm-commits]

FWIW here i have no real preference now, probably. Both ways looks reasonable to me.
One way avoids minor code duplication, second one avoids returning a value.

I think we can commit any way and switch to different one if we will want it,
probably no much sence to really argue here atm.. ?

Best regards,
George | Developer | Access Softek, Inc

________________________________________
От: Rafael Avila de Espindola <rafael.espindola at gmail.com>
Отправлено: 15 июня 2017 г. 21:46
Кому: reviews+D34221+public+1dc387a13f049d40 at reviews.llvm.org; George Rimar; ruiu at google.com
Копия: emaste at freebsd.org; Evgeny Leviant; llvm-commits at lists.llvm.org
Тема: Re: [PATCH] D34221: [ELF] - Resolve references properly when using .symver directive (2)

I prefer the bool return because it is less duplication. Otherwise we
have two places in the code that know that @@ has special meaning.

Cheers,
Rafael

Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:

> ruiu added a comment.
>
> I don't think we should return a `bool` value from a parser function unless it really improves performance. Essentially it is a speed hack, so it needs to be proven that it is effective.
>
>
> https://reviews.llvm.org/D34221