[PATCH] D34168: [cfi] CFI-ICall for ThinLTO.
Evgenii Stepanov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 14 15:57:55 PDT 2017
eugenis added inline comments.
================
Comment at: include/llvm/Support/YAMLTraits.h:662
+ if (this->canElideEmptySequence() &&
+ SequenceTraits<T>::size(*this, Val) == 0)
return;
----------------
pcc wrote:
> This is only necessary because of `StringSetYaml`, right?
Right. Still seems like the right thing to do. I've uploaded it as a separate NFC revision in D34116.
================
Comment at: lib/Transforms/IPO/LowerTypeTests.cpp:1498
+ auto &V = ExportedFunctions[FunctionName];
+ if (isDefinition >= V.first)
+ V = {isDefinition, FuncMD};
----------------
pcc wrote:
> I think this would be clearer as `if (!V.first)`.
>
> Could `V.first` be uninitialized at this point?
It's initialized to zero, which is what we want.
Repository:
rL LLVM
https://reviews.llvm.org/D34168
More information about the llvm-commits
mailing list