[PATCH] D34181: MachineInstr: Reason locally about some memory objects before going to AA.

[Balaram Makam via Phabricator via llvm-commits]

bmakam added inline comments.


================
Comment at: lib/CodeGen/MachineInstr.cpp:1664
+  int64_t WidthB = MMOb->getSize();
+  bool SameVal = MMOa->getValue() == MMOb->getValue();
+  if (!SameVal) {
----------------
gberry wrote:
> I don't think this is right since getValue() will return nullptr for any PseudoSourceValue, so SameVal will always be true for any two PseudoSourceValues, even if they are different.
I am not sure I fully understand your comment, getValue will not return nullptr here because of the earlier condition that returns true (i.e. mayAlias) if it was nullptr.


https://reviews.llvm.org/D34181