[llvm] r305415 - NewGVN: This is wrong by inspection, it will not cause an issue currently due to other limitations, i believe. This also means i can't make a test for it.

Daniel Berlin via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 14 14:19:29 PDT 2017


Author: dannyb
Date: Wed Jun 14 16:19:28 2017
New Revision: 305415

URL: http://llvm.org/viewvc/llvm-project?rev=305415&view=rev
Log:
NewGVN: This is wrong by inspection, it will not cause an issue currently due to other limitations, i believe.  This also means i can't make a test for it.

Modified:
    llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp

Modified: llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp?rev=305415&r1=305414&r2=305415&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp Wed Jun 14 16:19:28 2017
@@ -2195,7 +2195,7 @@ void NewGVN::moveValueToNewCongruenceCla
 // For a given expression, mark the phi of ops instructions that could have
 // changed as a result.
 void NewGVN::markPhiOfOpsChanged(const Expression *E) {
-  touchAndErase(ExpressionToPhiOfOps, E);
+  touchAndErase(ExpressionToPhiOfOps, ExactEqualsExpression(*E));
 }
 
 // Perform congruence finding on a given value numbering expression.




More information about the llvm-commits mailing list