[PATCH] D34197: Added Dockerfiles to build clang from sources.

Ilya Biryukov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 14 02:31:22 PDT 2017


ilya-biryukov added inline comments.


================
Comment at: utils/docker/build_docker_image.sh:40
+echo "Building $DOCKER_REPOSITORY-build$DOCKER_TAG"
+docker build -t "$DOCKER_REPOSITORY-build$DOCKER_TAG" \
+  --build-arg "buildscript_args=$*" \
----------------
klimek wrote:
> Perhaps check that docker is installed at the beginning. Also, did you by chance try all this on a mac?
Added the check.
Haven't tried on a Mac yet. Will do that.


https://reviews.llvm.org/D34197





More information about the llvm-commits mailing list