[PATCH] D34188: Don't check side effects for functions outside of SCoP

[Tobias Grosser via Phabricator via llvm-commits]

grosser added a subscriber: sylvestre.ledru.
grosser added a comment.

Forgot one comment.



================
Comment at: lib/Support/SCEVValidator.cpp:396
 
   ValidatorResult visitUnknown(const SCEVUnknown *Expr) {
     Value *V = Expr->getValue();
----------------
singam-sanjay wrote:
> How is this function called ? I don't find any explicit call to this function and the code [[ http://llvm.org/reports/coverage/tools/polly/lib/Support/SCEVValidator.cpp.gcov.html | coverage reports ]] are a month old.
I wrote an email to @sylvestre.ledru (see llvm-dev) to check about the status of the coverage reports.

It is called by the SCEVVisitor which serves as base class for the SCEVValidator.


Repository:
  rL LLVM

https://reviews.llvm.org/D34188