[PATCH] D34177: [DWARF] Partial verification for .apple_names accelerator table in llvm-dwarfdump output.

[Spyridoula Gravani via Phabricator via llvm-commits]

sgravani marked 2 inline comments as done.
sgravani added a comment.





================
Comment at: test/tools/llvm-dwarfdump/X86/apple_names_verify_buckets.s:1
+# RUN: env ; llvm-mc %s -filetype obj -triple x86_64-apple-darwin -o - \
+# RUN: | not llvm-dwarfdump -verify - \
----------------
probinson wrote:
> Is the "env" necessary?  I don't recall seeing other tests that do that.
It wasn't, good catch. 


================
Comment at: test/tools/llvm-dwarfdump/X86/apple_names_verify_buckets.s:10
+# in llvm-dwarfdump, correctly identifies that 
+# the there is an invalid hash index for 
+# bucket[0] in the .apple_names section. 
----------------
probinson wrote:
> s/the there/there/
Not sure I addressed your comment, I fixed the text a bit.


https://reviews.llvm.org/D34177