[PATCH] D34177: [DWARF] Partial verification for .apple_names accelerator table in llvm-dwarfdump output.

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

A couple of minor comments inline.  I'm okay with this, assuming Adrian is.



================
Comment at: test/tools/llvm-dwarfdump/X86/apple_names_verify_buckets.s:1
+# RUN: env ; llvm-mc %s -filetype obj -triple x86_64-apple-darwin -o - \
+# RUN: | not llvm-dwarfdump -verify - \
----------------
Is the "env" necessary?  I don't recall seeing other tests that do that.


================
Comment at: test/tools/llvm-dwarfdump/X86/apple_names_verify_buckets.s:10
+# in llvm-dwarfdump, correctly identifies that 
+# the there is an invalid hash index for 
+# bucket[0] in the .apple_names section. 
----------------
s/the there/there/


https://reviews.llvm.org/D34177