[llvm] r305339 - Specified LLVM_ATTRIBUTE_NORETURN for ReportError.

Galina Kistanova via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 13 16:39:42 PDT 2017


Author: gkistanova
Date: Tue Jun 13 18:39:42 2017
New Revision: 305339

URL: http://llvm.org/viewvc/llvm-project?rev=305339&view=rev
Log:
Specified LLVM_ATTRIBUTE_NORETURN for ReportError.

Modified:
    llvm/trunk/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp

Modified: llvm/trunk/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp?rev=305339&r1=305338&r2=305339&view=diff
==============================================================================
--- llvm/trunk/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp (original)
+++ llvm/trunk/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp Tue Jun 13 18:39:42 2017
@@ -521,7 +521,7 @@ void DWARFDebugFrame::parse(DataExtracto
   while (Data.isValidOffset(Offset)) {
     uint32_t StartOffset = Offset;
 
-    auto ReportError = [StartOffset](const char *ErrorMsg) {
+    auto ReportError = [StartOffset](const char *ErrorMsg) LLVM_ATTRIBUTE_NORETURN {
       std::string Str;
       raw_string_ostream OS(Str);
       OS << format(ErrorMsg, StartOffset);
@@ -585,7 +585,6 @@ void DWARFDebugFrame::parse(DataExtracto
           switch (AugmentationString[i]) {
             default:
               ReportError("Unknown augmentation character in entry at %lx");
-              llvm_unreachable("ReportError should not return.");
             case 'L':
               LSDAPointerEncoding = Data.getU8(&Offset);
               break;




More information about the llvm-commits mailing list