[PATCH] D34138: [LLD][ELF] make default for get{ARM, AArch64}UndefinedRelativeWeakVA unreachable

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/InputSection.cpp:405-406
   switch (Type) {
+  // Unresolved branch relocations to weak references resolve to next
+  // instruction.
   case R_ARM_THM_JUMP11:
----------------
What does this comment explain?


================
Comment at: ELF/InputSection.cpp:437-438
   switch (Type) {
+  // Unresolved branch relocations to weak references resolve to next
+  // instruction.
   case R_AARCH64_CALL26:
----------------
Ditto


================
Comment at: ELF/InputSection.cpp:444
     return P + 4 + A;
-  default:
+  // Unresolved relative relocations to weak references resolve to the place
+  case R_AARCH64_PREL16:
----------------
to the place ...?


https://reviews.llvm.org/D34138