[PATCH] D34127: Make obj2yaml and yaml2obj support .debug$S and .debug$T sections

[Zachary Turner via llvm-commits]

I'll wait a bit since I'm in the middle of a separate large patch and in no
hurry to commit this, and I don't want to switch branches :)

On Tue, Jun 13, 2017 at 9:45 AM Reid Kleckner via Phabricator <
reviews at reviews.llvm.org> wrote:

> rnk added a subscriber: inglorion.
> rnk added a comment.
>
> I skimmed over the rest of the code, and I didn't have any major comments.
> Do you want to give @inglorion a chance to review, or go ahead and commit?
>
>
>
> ================
> Comment at: lld/test/COFF/Inputs/pdb1.yaml:33-34
> +              Version:         'Microsoft (R) Optimizing Compiler'
> +      - !Symbols
> +        Records:
> +          - Kind:            S_GPROC32_ID
> ----------------
> zturner wrote:
> > rnk wrote:
> > > Is there a way we can fold !Symbols and Records: together? They're
> both plural, but !Symbols always consists of a list of records.
> > Looked into this and while I think it's technically supported by the
> YAML spec (What goes under a tag is defined to be "application specific",
> so I guess it could be anything, and [[
> http://www.yaml.org/spec/1.2/spec.html#id2761292 | example 2.24 ]] even
> seems to be an exact match for what we want to do (e.g. the `!shape` tag
> followed immediately by a list)), I don't think our YAML parser supports
> it.  In order to map a block sequence, we have to give it a name.  The
> specification for [[
> http://www.yaml.org/spec/1.2/spec.html#style/block/sequence | block
> sequences ]] doesn't seem to require that a block sequence have a name, but
> otoh the syntax used in the yaml spec is hard to make sense of, so maybe I
> missed something.
> >
> > TL;DR - Probably could do it, but non-trivial.
> Oh well.
>
>
> https://reviews.llvm.org/D34127
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170613/00b6f599/attachment.html>