[PATCH] D34136: [Solaris] replace Solaris.h hack with a set of better hacks

[Joerg Sonnenberger via Phabricator via llvm-commits]

joerg added inline comments.


================
Comment at: include/llvm/Support/Host.h:25
+#elif defined(__sun)
+/* Solaris doesn't have endian.h. SPARC is the only supported big-endian ISA. */
+#define BIG_ENDIAN 4321
----------------
Can't you use sys/byteorder.h or is that post-Solaris11?


================
Comment at: include/llvm/Support/Solaris/sys/regset.h:10
  *
- * This file contains portability fixes for Solaris hosts.
+ * This file is a special portability hack for Solaris hosts.
  *
----------------
Maybe:

This file works around excessive name space pollution from the system header on Solaris hosts.


https://reviews.llvm.org/D34136