[PATCH] D34048: [PowerPC] Eliminate compares - add i32 sext/zext handling for SETLE/SETGE

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 13 05:17:10 PDT 2017


nemanjai added inline comments.


================
Comment at: lib/Target/PowerPC/PPCISelDAGToDAG.cpp:2816
+// parameters for whether the RHS is -1/0/1.
+static void swapAndReset(SDValue &LHS, SDValue &RHS, bool &IsRHSZero,
+                         bool &IsRHSOne, bool &IsRHSNegOne) {
----------------
I realize that the three by-ref bool's makes this signature look kind of busy. Perhaps it would be better to just encode these as bits in a single `char` or something along those lines?


Repository:
  rL LLVM

https://reviews.llvm.org/D34048





More information about the llvm-commits mailing list