[PATCH] D34135: [LVI] Add initial result to avoid infinite getValueFromCondition recursion

Mikael Holmén via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 13 01:22:26 PDT 2017


uabelho added a comment.

I don't know this code at all, but the change at least seems to solve PR33357. Opinions?



================
Comment at: lib/Analysis/LazyValueInfo.cpp:1354
+  // entry bb.
+  Visited[Cond] = LVILatticeVal::getOverdefined();
+
----------------
I have no idea if "overdefined" is the proper thing to use here, or if we should set it to "undefined" (by calling the LVILatticeVal() constructor)? Any opinions?


https://reviews.llvm.org/D34135





More information about the llvm-commits mailing list