[PATCH] D20217: Add direct control of whether or not a symbol is preemtable at runtime

[Hiroshi Inoue via Phabricator via llvm-commits]

inouehrs added a comment.

Which word is more common, `preemptable` or `preemptible`?
This patch uses `preemptable`, and the discussion here uses both. `man elf` on Linux uses `preemptible`.



================
Comment at: include/llvm/IR/GlobalValue.h:89
         DllStorageClass(DefaultStorageClass), ThreadLocal(NotThreadLocal),
-        HasLLVMReservedName(false), IntID((Intrinsic::ID)0U), Parent(nullptr) {
+        HasLLVMReservedName(false), DSOLocation(DSO_Default), IntID((Intrinsic::ID)0U), Parent(nullptr) {
     setName(Name);
----------------
nit: It is better to break a line; this line seems too long. 


================
Comment at: include/llvm/IR/GlobalValue.h:298
   }
+
   static bool isLinkOnceLinkage(LinkageTypes Linkage) {
----------------
nit: Unnecessary white line?


Repository:
  rL LLVM

https://reviews.llvm.org/D20217