[PATCH] D34009: [Power9] Exploit vector integer extend instructions when indices aren't correct

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 12 21:51:38 PDT 2017


nemanjai added inline comments.


================
Comment at: test/CodeGen/PowerPC/vec_int_ext.ll:4
+; RUN: llc -verify-machineinstrs -mtriple=powerpc64-unknown-gnu-linux -mcpu=pwr9 < %s | FileCheck %s -check-prefix=CHECK-BE
+
+define <4 x i32> @vextsb2wLE(<16 x i8> %a) {
----------------
syzaara wrote:
> nemanjai wrote:
> > Please add a test that checks that there are no shuffles when the input elements are correct.
> Each of these tests is already checking both correct and incorrect elements. The *LE tests are using correct elements for LE and so the BE pattern match should have the shuffle. The *BE tests are using correct elements for BE and so the LE pattern match should have the shuffle.
Ah I see. Not sure how I missed that. Sorry.


https://reviews.llvm.org/D34009





More information about the llvm-commits mailing list