[PATCH] D33059: Create an shared include directory for gtest helper functions

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 12 18:55:54 PDT 2017


MatzeB added a comment.

about the directories: 'meh'. I'm fine with whatever works.

- Why is a patch that claims to create a shared include directory actually changing so many unit tests?
- `EXPECT_THAT_ERROR(x, Succeeded())` seems bad. SHouldn't this rather be `EXPECT_THAT(x, succeeded())` to look more natural?


https://reviews.llvm.org/D33059





More information about the llvm-commits mailing list