[PATCH] D34127: Make obj2yaml and yaml2obj support .debug$S and .debug$T sections

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 12 18:31:23 PDT 2017


rnk added inline comments.


================
Comment at: lld/test/COFF/Inputs/pdb1.yaml:33-34
+              Version:         'Microsoft (R) Optimizing Compiler'
+      - !Symbols
+        Records:         
+          - Kind:            S_GPROC32_ID
----------------
Is there a way we can fold !Symbols and Records: together? They're both plural, but !Symbols always consists of a list of records.


================
Comment at: lld/test/COFF/Inputs/pdb1.yaml:72
+      - !FileChecksums
+        Checksums:       
+          - FileName:        'd:\b\ret42-main.c'
----------------
Excellent! =D


https://reviews.llvm.org/D34127





More information about the llvm-commits mailing list