[PATCH] D34065: make AnnotatedBuilder use LLVMBuildFactory and depends_on_projects

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 12 17:12:45 PDT 2017


rnk added a comment.

In https://reviews.llvm.org/D34065#778428, @inglorion wrote:

> What do you mean by "the scheduling logic gets out of sync"?


Suppose ThinLTO develops a dependency on libprofile in compiler-rt. If we update the annotator script to check out compiler-rt without updating the depends_on_projects list on the buildmaster, then builds will not be scheduled after compiler-rt changes. By using depends_on_projects, we're moving the knowledge of what source to check out back into the build master config. If adding a new subproject dependency requires a buildmaster restart, maybe we should go back to using the master side SVN checkout steps.


https://reviews.llvm.org/D34065





More information about the llvm-commits mailing list