[PATCH] D33575: [llvm-ar] Make llvm-lib behave more like the MSVC archiver

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 12 12:32:55 PDT 2017


rnk added a comment.

I rewrote the patch to store the name in the NewArchiveMember. I think initially I avoided this approach because it duplicates the member name between the MemoryBuffer and the NewArchiveMember, and it still isn't the final name for thin archives. I kind of liked centralizing the member name calculation logic in `writeArchive`. However, looking at it now, this definitely feels cleaner. :)


https://reviews.llvm.org/D33575





More information about the llvm-commits mailing list