[PATCH] D34080: [ThinLTO] Add dump-summary command to llvm-lto2 tool

[Charles Saternos via Phabricator via llvm-commits]

ncharlie marked an inline comment as done.
ncharlie added inline comments.


================
Comment at: test/tools/llvm-lto2/X86/dump-summary.ll:2
+; RUN: opt -module-summary %s -o %t.o
+; RUN: llvm-lto2 dump-summary %t.o | egrep 'Linkage:\s+0'
+; RUN: llvm-lto2 dump-summary %t.o | egrep 'Live:\s+false'
----------------
tejohnson wrote:
> Rather than repeating this command and piping through egrep, you should run once and pipe through FileCheck (see the other tests in this directory for examples). I.e. pipe through "FileCheck %s", then have several lines prefixed by "CHECK: "  to look for the expected output. E.g.:
> 
> CHECK: NotEligibleToImport: false
> 
Oh, cool - I saw FileCheck before, but assumed that the 'CHECK' lines had to be outputted throughout the pipeline and couldn't be fed into FileCheck like that. I fixed it.


https://reviews.llvm.org/D34080