[PATCH] D34067: Use symbols with the default version to resolve unversioned symbols.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/ELF/SymbolTable.cpp:780
+    if (Ver.Name == Verstr) {
+      Version = Ver.Id;
+      return;
----------------
ruiu wrote:
> grimar wrote:
> > So Version can have valid 0 value it seems ?
> > 
> > But below you do check for 0:
> > 
> > ```
> >     if (Ver != 0)
> >       Sym->VersionId = IsDefault ? Ver : (Ver | VERSYM_HIDDEN);
> > ```
> > 
> > That become visible and confusing for me mostly because of mutating arguments.
> > (I was a bit lost in what this method do in general).
> I could fix it.
Take your time. No reason to rush.


https://reviews.llvm.org/D34067