[PATCH] D33575: [llvm-ar] Make llvm-lib behave more like the MSVC archiver
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 12 10:14:17 PDT 2017
ruiu added a comment.
I wonder how many uses of this class in LLVM. I'm asking because it feels more cleaner to me if you remove `WriteObjPaths` parameter from `writeArchive` and strip directories if it's needed on the client side.
================
Comment at: llvm/lib/Object/ArchiveWriter.cpp:290
+ // Replace Name with the short raw name.
+ Name = std::move(RawName);
}
----------------
This could be
Name = (Twine('/') + Twine(StringMapIndex)).str();
?
https://reviews.llvm.org/D33575
More information about the llvm-commits
mailing list