[PATCH] D34087: [X86] EltsFromConsecutiveLoads - detect split loads without a common load base (PR32940)

Nirav Dave via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 12 06:18:26 PDT 2017


niravd added a comment.

It looks like this is really an issue of  "areNonVolatileConsecutiveLoads" not being clever enough. BaseIndexOffset in DAGCombiner should do better. I'd favor moving BaseIndexOffset out of the DAG Combiner and rewriting areNonVolatileConsecutiveLoads off of that.

Also, popping up a level, do you know if there's a reason why this is done as an X86-specific pass? It seems entirely generic.


Repository:
  rL LLVM

https://reviews.llvm.org/D34087





More information about the llvm-commits mailing list