[llvm] r305158 - [SmallVector] Reinstate the typedefs.

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 11 21:51:36 PDT 2017


Do we have something like `(void)unused_var;` that we could use here?

On Sat, Jun 10, 2017 at 4:18 PM, Davide Italiano via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: davide
> Date: Sat Jun 10 18:18:32 2017
> New Revision: 305158
>
> URL: http://llvm.org/viewvc/llvm-project?rev=305158&view=rev
> Log:
> [SmallVector] Reinstate the typedefs.
>
> They're unused with recent versions of libstdc++ but older ones
> (e.g. libstdc++ 4.9 still requires them). Maybe we should bump
> the requirements on the minimum version to make GCC 7 happy, but
> in the meanwhile we need to live with the warning.
>
> Modified:
>     llvm/trunk/unittests/ADT/SmallVectorTest.cpp
>
> Modified: llvm/trunk/unittests/ADT/SmallVectorTest.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ADT/SmallVectorTest.cpp?rev=305158&r1=305157&r2=305158&view=diff
> ==============================================================================
> --- llvm/trunk/unittests/ADT/SmallVectorTest.cpp (original)
> +++ llvm/trunk/unittests/ADT/SmallVectorTest.cpp Sat Jun 10 18:18:32 2017
> @@ -446,6 +446,9 @@ TYPED_TEST(SmallVectorTest, AppendRepeat
>    struct output_iterator {
>      typedef std::output_iterator_tag iterator_category;
>      typedef int value_type;
> +    typedef int difference_type;
> +    typedef value_type *pointer;
> +    typedef value_type &reference;
>      operator int() { return 2; }
>      operator Constructable() { return 7; }
>    };
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list